feat(fluentbit): Add db.compare_filename support to Tail input plugin#1961
Open
fumblehool wants to merge 2 commits into
Open
feat(fluentbit): Add db.compare_filename support to Tail input plugin#1961fumblehool wants to merge 2 commits into
fumblehool wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the Fluent Bit Tail input plugin CRD/API surface to support Fluent Bit’s db.compare_filename option, allowing users to control whether the Tail plugin compares filenames when using its state database.
Changes:
- Added
dbCompareFilenameto the Tail input plugin API type and ensured it’s rendered into Fluent Bit config asDB.compare_filename. - Regenerated CRDs/manifests/Helm CRD artifacts to expose the new field in the published schemas.
- Updated Tail plugin documentation to include the new parameter.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| manifests/setup/setup.yaml | Exposes dbCompareFilename in the generated setup manifest CRD schema. |
| manifests/setup/fluent-operator-crd.yaml | Exposes dbCompareFilename in the consolidated generated CRD manifest. |
| docs/plugins/fluentbit/input/tail.md | Documents the new dbCompareFilename option for Tail. |
| config/crd/bases/fluentbit.fluent.io_clusterinputs.yaml | Adds dbCompareFilename to the ClusterInput CRD base schema for Tail. |
| charts/fluent-operator/crds/fluentbit.fluent.io_clusterinputs.yaml | Propagates the CRD schema update into the Helm chart CRD bundle. |
| charts/fluent-operator-fluent-bit-crds/templates/fluentbit.fluent.io_clusterinputs.yaml | Propagates the CRD schema update into the Fluent Bit CRD Helm chart template. |
| apis/fluentbit/v1alpha2/plugins/input/zz_generated.deepcopy.go | Regenerated deepcopy logic to include DBCompareFilename. |
| apis/fluentbit/v1alpha2/plugins/input/tail_types.go | Adds DBCompareFilename to the Tail type and emits DB.compare_filename in Params(). |
Files not reviewed (1)
- apis/fluentbit/v1alpha2/plugins/input/zz_generated.deepcopy.go: Language not supported
fumblehool
force-pushed
the
master
branch
2 times, most recently
from
8ec6980 to
c66f304
Compare
Signed-off-by: damanpreetsingh <damanpreetsingh@digitalocean.com>
joshuabaird
changed the title
joshuabaird
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds
db.compare_filenamesupport to Tail input plugindocs: https://docs.fluentbit.io/manual/data-pipeline/inputs/tail#configuration-parameters