Fix: Add missing import for Bounce transition in documentation examples#1273
Open
Moamen-w-a wants to merge 2 commits intofkhadra:mainfrom
Open
Fix: Add missing import for Bounce transition in documentation examples#1273Moamen-w-a wants to merge 2 commits intofkhadra:mainfrom
Moamen-w-a wants to merge 2 commits intofkhadra:mainfrom
Conversation
- Update playground ContainerCode to display import when non-default transition is used - Add example with Bounce import in README.md - Fix incorrect import in useNotificationCenter.ts from 'react-toastify' to relative path - Update isDefaultProps to include transition check Resolves issue fkhadra#1272: Incorrect example on documentation causing 'Bounce is not defined' error
- Changed import from 'react-toastify' to '../../index' in useNotificationCenter.ts - Updated test import to '../../../src' for consistency - Ensures build and tests work correctly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves issue #1273 : Incorrect example on documentation causing 'Bounce is not defined' error
Before submitting a pull request, please make sure the following is done:
main.pnpm iin the repository root.pnpm test).pnpm startto test your changes in the playground.pnpm prettier).pnpm lint:fix).For new features, please make sure that there is an issue related to it.
Learn more about contributing here