fix: Remove toasts from the waiting queue if they are dismissed.#1235
Open
JulianSelman wants to merge 2 commits intofkhadra:mainfrom
Open
fix: Remove toasts from the waiting queue if they are dismissed.#1235JulianSelman wants to merge 2 commits intofkhadra:mainfrom
JulianSelman wants to merge 2 commits intofkhadra:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Currently, if a toast is dismissed, it will be removed from the view if active. However, if the
ToastContaineris configured with a limit, excess toasts are added to an internal queue that will serve overflow toasts when active toasts are dismissed or time out. Toasts in this queue can be cleared viatoast.clearWaitingQueue(), but this will empty the queue entirely. It is not currently possible to remove a toast from the waiting queue by ID.Changes
This change augments the existing
toast.dismiss(id)function by not only dismissing the toast if active, but also removing any pending activity for a toast by that ID from the waiting queue. This feels appropriate, as someone explicitly dismissing a toast probably wants it gone, regardless of if it's currently active or waiting to be made active.Links
#1233