Fix clear all bug when promise has neither a pending nor a success/error#1112
Open
hufftheweevil wants to merge 1 commit intofkhadra:mainfrom
Open
Fix clear all bug when promise has neither a pending nor a success/error#1112hufftheweevil wants to merge 1 commit intofkhadra:mainfrom
hufftheweevil wants to merge 1 commit intofkhadra:mainfrom
Conversation
On resolving a promise, if there is no success/error, then the pending toast needs to be dismissed. But if there was no pending toast, then toast.dismiss() is being called with undefined, which clears all toast. It should only call toast.dimiss() if id exists for the pending toast.
| @@ -123,7 +123,7 @@ function handlePromise<TData = unknown, TError = unknown, TPending = unknown>( | |||
| // Remove the toast if the input has not been provided. This prevents the toast from hanging | |||
| // in the pending state if a success/error toast has not been provided. | |||
| if (input == null) { | |||
There was a problem hiding this comment.
Instead of writing double if, you can write in this way with single if -
if (!input && id) {
toast.dismiss(id);
return;
}or
if (input == null && id) {
toast.dismiss(id);
return;
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On resolving a promise, if there is no success/error, then the pending toast needs to be dismissed. But if there was no pending toast, then toast.dismiss() is being called with undefined, which clears all toast. It should only call toast.dimiss() if id exists for the pending toast.