test: run snapshot creation latency perf test in A/B and nightly#5266
Merged
roypat merged 6 commits intofirecracker-microvm:mainfrom Jun 18, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5266 +/- ##
==========================================
+ Coverage 82.84% 82.90% +0.05%
==========================================
Files 250 250
Lines 26967 26967
==========================================
+ Hits 22342 22356 +14
+ Misses 4625 4611 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kalyazin
previously approved these changes
Jun 17, 2025
Contributor
|
The optional tests are failing with some weird errors: |
So we track the metric better Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
There is nothing that makes these tests specifically "ab" - any test can be run as an A/B-test as long as it produces more than one data point for a metric. So drop this suffix. It was only added originally when we transitioned to A/B-testing and the A/B-capable versions of the tests had to co-exist with the old baseline version of the tests in separate files. Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
We have a few tests that are parametrized to run with both full and diff snapshots enabled, so let's move this into a fixture. Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
Diff snapshots create sparse files, so they should be a lot faster than full snapshots. Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
7c4e913 to
65577a4
Compare
We were seeing "import mismatch error" due to files in functional and performance having the same name. According to [1], a fix is to just have __init__.py files. [1]: https://stackoverflow.com/questions/53918088/import-file-mismatch-in-pytest Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
65577a4 to
cf7dfbe
Compare
Contributor
Author
Fixed! |
kalyazin
approved these changes
Jun 18, 2025
Manciukic
approved these changes
Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.