Local Build env vars should NOT be set on the global process#10538
Open
falahat wants to merge 18 commits into
Open
Local Build env vars should NOT be set on the global process#10538falahat wants to merge 18 commits into
falahat wants to merge 18 commits into
Conversation
…sal_maker_upgrade
…dentally inject raw secret values into the terminal.
… readFileSync stub
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors environment variable handling during local builds by passing them explicitly through function arguments instead of mutating the global process.env. Feedback focuses on improving type safety by using NodeJS.ProcessEnv instead of generic records and replacing any types in test stubs with proper TypeScript definitions to align with the repository's style guide.
# Conflicts: # src/deploy/apphosting/util.spec.ts # src/deploy/apphosting/util.ts
abhis3
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Instead of modifying process.env, this sets env vars on the child process that runs universal maker.
Scenarios Tested
Performed a local build