fix(remoteconfig) Support Rollout realtime when variant value matches default value of parameter#10009
fix(remoteconfig) Support Rollout realtime when variant value matches default value of parameter#10009athiramanu wants to merge 10 commits into
Conversation
…nts, and personalization
…ion in RealtimeHandler
🦋 Changeset detectedLatest commit: d494b44 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for Remote Config rollouts in the realtime handler. It adds the FirebaseRolloutMetadata interface, updates FetchResponse to include rollout metadata, and updates RealtimeHandler to compare rollout metadata and experiment descriptions when identifying changed keys. Unit tests have also been added to cover these changes. The reviewer suggested adding a defensive check in createRolloutsMap to prevent a potential TypeError if affectedParameterKeys is missing or undefined in the server response.
athiramanu
changed the title
1 participant
Updated to detect changes in Rollout experiment metadata. This ensures that if a rollout variant or affected parameter keys
change, the associated config keys are correctly identified as changed, even if the parameter values remain the same.
Screencast: http://go/scrcast/NjI4ODYxNjA3NzY1NjA2NHxlNDRiM2Y5Ni1lNg