gRPC server#12
Merged
fibonacci1729 merged 1 commit intofermyon:mainfrom Oct 2, 2025
Merged
Conversation
Signed-off-by: itowlson <ivan.towlson@fermyon.com>
Collaborator
|
Sorry for the delay, I don't know how I missed this! I'll review tomorrow! |
fibonacci1729
approved these changes
Oct 2, 2025
Collaborator
fibonacci1729
left a comment
fibonacci1729
left a comment
There was a problem hiding this comment.
This is all looks great! Re: organization, i think what you have here is the way to go.
Contributor
Author
|
@fibonacci1729 If you're happy with this as is, could you merge it please? (I don't have permissions.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This folds the WASI gRPC server crate (currently in a separate repo) into this one, so that all our Rust WASI gRPC stuff is in one place.
I have slightly mixed feelings about this because I worry it entangles the release processes in ways that aren't useful. But I'll leave it up to other folks to make the call - if we decide we like it this way then we'll figure something out.