feat: Add versioning support to Milvus online store#6330
Merged
franciscojavierarceo merged 4 commits intofeast-dev:masterfrom Apr 28, 2026
Merged
Conversation
makinzm
requested review from
HaoXuAI,
nquinn408 and
redhatHameed
and removed request for
a team
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
ntkathole
changed the title
Member
|
@makinzm please fix the linting |
ntkathole
reviewed
Apr 25, 2026
| self.client = self._connect(config) | ||
| for table in tables: | ||
| collection_name = _table_id(config.project, table) | ||
| collection_name = _table_id( |
Member
There was a problem hiding this comment.
No cleanup of old versioned collections, it needs to list all collections matching the base name pattern and drop them.
Contributor
Author
There was a problem hiding this comment.
Thank you for reviewing. I fixed it 161aab7
Summary of the change:
- Added a
_drop_all_version_collectionshelper that drops the base collection plus every_v{N}sibling, mirroring the_drop_all_version_tableshelpers used by the MySQL and PostgreSQL online stores. updateandteardownnow call this helper unconditionally (i.e. regardless of the currentenable_online_feature_view_versioningflag), so repos that toggle versioning on and off across applies don't leave orphan collections behind in Milvus.- Added unit tests covering both
teardownandupdate, including an unrelated collection that must not be dropped.
Contributor
Author
There was a problem hiding this comment.
I forgot to check mypy so I will fix 🙇
Signed-off-by: makinzm <[email protected]>
…online_store/milvus.py Signed-off-by: makinzm <[email protected]>
Signed-off-by: makinzm <[email protected]>
Signed-off-by: makinzm <[email protected]>
ntkathole
force-pushed
the
feast/milvus-online-store-versioning
branch
from
5fad6e8 to
3f2989a
Compare
ntkathole
approved these changes
Apr 28, 2026
franciscojavierarceo
merged commit 3268ced
into
feast-dev:master
33 of 35 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds feature view versioning support to the Milvus online store. When
enable_online_feature_view_versioningis enabled in the registry config, the Milvus collection name now includes a version suffix (e.g.project_driver_stats_v2), allowing version-qualified feature references (e.g.driver_stats@v2:trips_today) to resolve to the correct versioned data.Changes:
_table_id()inmilvus.pyto acceptenable_versioningand delegate to the sharedcompute_table_id()helper (same pattern as SQLite, Redis, PostgreSQL, etc.)_table_idto passconfig.registry.enable_online_feature_view_versioningMilvusOnlineStoreto the supported types list in_check_versioned_read_support()so versioned reads no longer raiseVersionedOnlineReadNotSupportedWhich issue(s) this PR fixes:
Fixes #6177
Checks
git commit -s)Testing Strategy
Misc
Implementation follows the existing pattern from
sqlite.pyanddynamodb.py. Thecompute_table_id()helper inhelpers.pyhandles the version suffix logic, so no additional logic was needed in the Milvus store itself.