fix(focus-trap): activate only when step content is visible (#126)#127
Merged
fatihsolhan merged 3 commits intomainfrom Jan 23, 2026
Merged
fix(focus-trap): activate only when step content is visible (#126)#127fatihsolhan merged 3 commits intomainfrom
fatihsolhan merged 3 commits intomainfrom
Conversation
- Move Nuxt module output to dist/nuxt/ for cleaner build structure - Add support for Vue component refs in attachTo.element - Add null-safe checks for element.style to prevent SSR errors - Refactor interaction functions for better code clarity
✅ Deploy Preview for v-onboarding canceled.
|
✅ Deploy Preview for v-onboarding-docs canceled.
|
|
🎉 This PR is included in version 2.12.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
readystate instead ofshowfor focus trap activationProblem
The focus trap was activating when
showbecame true, but at that pointreadywas still false, causingvisibility: hiddenon the step content.Elements with
visibility: hiddenare not considered tabbable by the focus-trap library, resulting in the error.Solution
Changed the watch from
showtoready, ensuring the focus trap only activates when the step content is actually visible and its elements are tabbable.Fixes #126