chore(plugins/container): deprecate container probe fields#1265
Open
chore(plugins/container): deprecate container probe fields#1265
Conversation
…hcheck, readiness, liveness) Signed-off-by: Leonardo Grasso <[email protected]>
…lated fields Signed-off-by: Leonardo Grasso <[email protected]>
Signed-off-by: Leonardo Grasso <[email protected]>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leogr The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Rules files suggestions |
Member
Author
|
/hold Waiting for double-checking |
ekoops
reviewed
Mar 30, 2026
Comment on lines
-614
to
-617
| field_id != TYPE_CONTAINER_DURATION && | ||
| field_id != TYPE_IS_CONTAINER_HEALTHCHECK && | ||
| field_id != TYPE_IS_CONTAINER_LIVENESS_PROBE && | ||
| field_id != TYPE_IS_CONTAINER_READINESS_PROBE) |
Contributor
There was a problem hiding this comment.
Since we left some handling code for these TYPE_* few lines after these ones, isn't it better to also leave these ones here? Another option could be to remove both these and the following ones.
irozzo-1A
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area plugins
What this PR does / why we need it:
Deprecate
container.healthcheck,container.liveness_probe,container.readiness_probeand the relatedproc.is_container_*fields.These fields rely on the
kubectl.kubernetes.io/last-applied-configurationannotation, which is fragile and K8s-specific. Moreover, liveness/readiness probes never worked for CRI runtimes, they just were implemented only for Docker.As discussed in #1218 (which I'm going to close in favor of this), the consensus is to deprecate them here and eventually move the functionality to the
k8smetaplugin.Which issue(s) this PR fixes:
Fixes #1017
Special notes for your reviewer:
The Falco deprecation policy for stable features technically requires 1 release cycle of functioning-while-deprecated before removal. However, I believe deprecating and making these fields no-op in the same release is acceptable here for the following reasons:
k8s.*fields (k8s.rc.*,k8s.svc.*,k8s.rs.*,k8s.deployment.*) were deprecated the exact same way (deprecated + no-op in the same release)That said, if anyone disagrees with this approach, we can go with a strict two-phase deprecation instead:
0.7.0= deprecated but still functional for Docker, next release = no-op. Let me know 🙏