fix(cmake): enable webserver deps on macOS (httplib include/link)#3832
fix(cmake): enable webserver deps on macOS (httplib include/link)#3832yoderme wants to merge 3 commits intofalcosecurity:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: yoderme The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @yoderme! It looks like this is your first PR to falcosecurity/falco 🎉 |
Root CMake skipped openssl/curl/cpp-httplib and c-ares on APPLE while state.h still included webserver.h on all non-Windows Unix builds, causing missing httplib.h on Darwin. Align userspace/falco targets with those conditions, fix FALCO_INCLUDE_DIRECTORIES typo, and gate CPPHTTPLIB_OPENSSL_SUPPORT with the webserver block. Signed-off-by: Mike Yoder <[email protected]>
36e8e19 to
8dfcb34
Compare
Signed-off-by: Mike Yoder <[email protected]>
|
/milestone 0.44.0 |
|
Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits. 📝 Please follow instructions in the contributing guide to update your commits with the DCO Full details of the Developer Certificate of Origin can be found at developercertificate.org. The list of commits missing DCO signoff:
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Hey @yoderme The last commit is missing the DCO signoff. To fix it, you should run something like this: (this assumes you forked this repository and the upstream remote is called Thanks |
Root CMake skipped openssl/curl/cpp-httplib and c-ares on APPLE while state.h still included webserver.h on all non-Windows Unix builds, causing missing httplib.h on Darwin. Align userspace/falco targets with those conditions, fix FALCO_INCLUDE_DIRECTORIES typo, and gate CPPHTTPLIB_OPENSSL_SUPPORT with the webserver block.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #3831
Special notes for your reviewer:
Does this PR introduce a user-facing change?: