Skip to content

fix(cmake): enable webserver deps on macOS (httplib include/link)#3832

Open
yoderme wants to merge 3 commits intofalcosecurity:masterfrom
yoderme:myoder/fix-build-on-macos
Open

fix(cmake): enable webserver deps on macOS (httplib include/link)#3832
yoderme wants to merge 3 commits intofalcosecurity:masterfrom
yoderme:myoder/fix-build-on-macos

Conversation

@yoderme
Copy link
Copy Markdown

@yoderme yoderme commented Mar 20, 2026

Root CMake skipped openssl/curl/cpp-httplib and c-ares on APPLE while state.h still included webserver.h on all non-Windows Unix builds, causing missing httplib.h on Darwin. Align userspace/falco targets with those conditions, fix FALCO_INCLUDE_DIRECTORIES typo, and gate CPPHTTPLIB_OPENSSL_SUPPORT with the webserver block.

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area tests

/area proposals

/area CI

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #3831

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix(cmake): enable webserver deps (httplib) on macOS

@poiana
Copy link
Copy Markdown
Contributor

poiana commented Mar 20, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yoderme
Once this PR has been reviewed and has the lgtm label, please assign jasondellaluce for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Copy Markdown
Contributor

poiana commented Mar 20, 2026

Welcome @yoderme! It looks like this is your first PR to falcosecurity/falco 🎉

@poiana poiana added the size/S label Mar 20, 2026
Root CMake skipped openssl/curl/cpp-httplib and c-ares on APPLE while
state.h still included webserver.h on all non-Windows Unix builds,
causing missing httplib.h on Darwin. Align userspace/falco targets with
those conditions, fix FALCO_INCLUDE_DIRECTORIES typo, and gate
CPPHTTPLIB_OPENSSL_SUPPORT with the webserver block.

Signed-off-by: Mike Yoder <[email protected]>
Signed-off-by: Mike Yoder <[email protected]>
@leogr
Copy link
Copy Markdown
Member

leogr commented Mar 26, 2026

/milestone 0.44.0

@poiana poiana added this to the 0.44.0 milestone Mar 26, 2026
@poiana
Copy link
Copy Markdown
Contributor

poiana commented Mar 26, 2026

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@poiana poiana added size/M and removed size/S labels Mar 26, 2026
@leogr
Copy link
Copy Markdown
Member

leogr commented Mar 26, 2026

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

Details

Hey @yoderme

The last commit is missing the DCO signoff. To fix it, you should run something like this:

git rebase --signoff -i upstream/master

(this assumes you forked this repository and the upstream remote is called upstream, if not change it accordingly).

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

Build fails on macOS: httplib.h not found when compiling falco_application

3 participants