ci: add top-level permissions to workflow files#3818
Merged
poiana merged 1 commit intofalcosecurity:masterfrom Mar 11, 2026
Merged
ci: add top-level permissions to workflow files#3818poiana merged 1 commit intofalcosecurity:masterfrom
poiana merged 1 commit intofalcosecurity:masterfrom
Conversation
Add `permissions: contents: read` at the workflow level for bump-libs.yaml, format.yaml, master.yaml, and release.yaml to follow the principle of least privilege. Job-level permissions that require elevated access will override this as expected. Signed-off-by: Gagan H R <hrgagan4@gmail.com>
Contributor
Author
|
/assign @FedeDP |
FedeDP
approved these changes
Mar 11, 2026
Contributor
FedeDP
left a comment
FedeDP
left a comment
There was a problem hiding this comment.
LGTM, thank you very much!
/approve
Contributor
|
LGTM label has been added. DetailsGit tree hash: 8aa7ef30dcef62e71cb9bd05a180a82e29352193 |
sgaist
approved these changes
Mar 11, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, gaganhr94, sgaist The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area CI
What this PR does / why we need it:
Adds
permissions: contents: readat the workflow level forbump-libs.yaml,format.yaml,master.yaml, andrelease.yaml. This follows the principle of least privilege and addresses the OpenSSF Scorecard Token-Permissions findings. Job-level permissions that require elevated access (e.g.,contents: writeinbump-libs.yamlandrelease.yaml) will override the workflow-level setting as expected.Which issue(s) this PR fixes:
Fixes #3817
Special notes for your reviewer:
When both workflow-level and job-level permissions are defined, the job-level permissions completely override the workflow-level ones. So existing jobs with
contents: write(bump-libs, release) are unaffected.Does this PR introduce a user-facing change?: