cleanup(engine)!: only consider .yaml/.yml rule files#3551
Merged
poiana merged 3 commits intofalcosecurity:masterfrom May 12, 2025
Merged
cleanup(engine)!: only consider .yaml/.yml rule files#3551poiana merged 3 commits intofalcosecurity:masterfrom
poiana merged 3 commits intofalcosecurity:masterfrom
Conversation
Signed-off-by: Luca Guerra <[email protected]>
Signed-off-by: Luca Guerra <[email protected]>
Signed-off-by: Luca Guerra <[email protected]>
|
This PR may bring feature or behavior changes in the Falco engine and may require the engine version to be bumped. Please double check userspace/engine/falco_engine_version.h file. See versioning for FALCO_ENGINE_VERSION. /hold |
Contributor
Author
|
/unhold false positive |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
LGTM label has been added. DetailsGit tree hash: d6abc15c3e0d35df67e103e672b2eeb55ac91cb9 |
leogr
approved these changes
May 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
Normally, Falco would try to load any file or directory specified in
rules_filesor with the-roption. However, if you are trying to load a non-yaml file or a directory which contains both yaml and other types of files Falco would emit a fatal error on the first file that fails to load. Since it makes sense to put also other files in the rule directory (such as aREADME) this PR restricts the files that are considered to.yamland.yml, ignoring the rest. Likewise, single files that do not end in.ymlor.yamlwill not be loaded.Thanks to @tks98 for noticing the behavior and suggesting this improvement!
/milestone 0.41.0
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: