fix(userspace): fixed engine openssl dep.#3535
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/milestone 0.41.0 |
|
Tests for both archs are failing with a modern ebpf verifier issue :/ That's weird since this PR did not touch libs code, and also the kernel release of the runners seems to be the same of latest 🟢 CI: 6.8.0-1021-azure, see https://github.com/falcosecurity/falco/actions/runs/14472866793/job/40591307938 |
|
Spotted the diff; failing CI is using to build the modern bpf probe, while old CI is using: Probably |
|
#3537 will fix the CI issue. Will rebase on top of master once that is merged. |
| ) | ||
|
|
||
| set(FALCO_DEPENDENCIES cxxopts) | ||
| set(FALCO_LIBRARIES falco_engine sinsp yaml-cpp) |
There was a problem hiding this comment.
Both sinsp and yaml-cpp are inherited from falco_engine dep.
| "${GRPC_LIBRARIES}" | ||
| "${PROTOBUF_LIB}" | ||
| "${CARES_LIB}" | ||
| "${OPENSSL_LIBRARIES}" |
There was a problem hiding this comment.
Same as ☝️ goes for openssl.
Signed-off-by: Federico Di Pierro <[email protected]>
FedeDP
force-pushed
the
fix/engine_openssl_dep
branch
from
33315d1 to
f364b28
Compare
|
cc @sgaist :) |
4 participants
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #3532
Special notes for your reviewer:
Does this PR introduce a user-facing change?: