Fix ccache for GPU, Metal, and Windows CI builds (#5174)#5174
Open
mnorris11 wants to merge 1 commit intofacebookresearch:mainfrom
Open
Fix ccache for GPU, Metal, and Windows CI builds (#5174)#5174mnorris11 wants to merge 1 commit intofacebookresearch:mainfrom
mnorris11 wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
Contributor
|
@mnorris11 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D103482603. |
meta-codesync
Bot
changed the title
mnorris11
pushed a commit
to mnorris11/faiss
that referenced
this pull request
May 3, 2026
Summary: Fix ccache configuration to actually achieve cache hits across CI runs: 1. (P0) Configure ccache sloppiness for CUDA/ROCm builds — without `hash_dir=false` and relaxed sloppiness settings, nvcc/hipcc absolute paths cause 100% cache misses even when source is unchanged. 2. (P1) Add missing `-DCMAKE_C_COMPILER_LAUNCHER=ccache -DCMAKE_CXX_COMPILER_LAUNCHER=ccache` to the Metal build step, which had its own cmake invocation that was missed in D102926935. 3. (P2) Increase cache size from 2G to 4G for GPU builds since CUDA object files are significantly larger. 4. (P3) Add ccache to the Windows build in build-pull-request.yml, which uses inline build steps instead of the build_cmake composite action. Differential Revision: D103482603
mnorris11
force-pushed
the
export-D103482603
branch
from
a77f60f to
484095a
Compare
Summary: Fix ccache configuration to actually achieve cache hits across CI runs: 1. (P0) Configure ccache sloppiness for CUDA/ROCm builds — without `hash_dir=false` and relaxed sloppiness settings, nvcc/hipcc absolute paths cause 100% cache misses even when source is unchanged. 2. (P1) Add missing `-DCMAKE_C_COMPILER_LAUNCHER=ccache -DCMAKE_CXX_COMPILER_LAUNCHER=ccache` to the Metal build step, which had its own cmake invocation that was missed in D102926935. 3. (P2) Increase cache size from 2G to 4G for GPU builds since CUDA object files are significantly larger. 4. (P3) Add ccache to the Windows build in build-pull-request.yml, which uses inline build steps instead of the build_cmake composite action. Differential Revision: D103482603
mnorris11
force-pushed
the
export-D103482603
branch
from
484095a to
af91c82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fix ccache configuration to actually achieve cache hits across CI runs:
hash_dir=falseand relaxed sloppiness settings, nvcc/hipcc absolute paths cause 100% cache misses even when source is unchanged.-DCMAKE_C_COMPILER_LAUNCHER=ccache -DCMAKE_CXX_COMPILER_LAUNCHER=ccacheto the Metal build step, which had its own cmake invocation that was missed in D102926935.Differential Revision: D103482603