Draft
Conversation
aknayar
commented
Apr 4, 2026
| } | ||
|
|
||
| float lower_bound = exact_distances[idx] - cauchy_schwarz_bound; | ||
| if constexpr (C::is_max) { |
Contributor
Author
There was a problem hiding this comment.
Unfortunately C::cmp() kills autovectorization here so we resort to this workaround.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Should be merged before #4970 (IVFPQPanorama).
Changes
Performance
This PR implements various optimizations to Panorama (L2Flat and IVFFlat).
if constexpr (C::is_max)instead ofC::cmpfor autovectorized pruning._pext_u64.active_indicesindirection) to let it autovectorize.IndexFlat/IVFFlatScannerPanorama.Other
kDefaultBatchSizeonce inPanorama.h(previously defined in 5 separate locations).bench_flat_l2_panorama.pyandbench_ivf_flat_panorama.pyto acceptgist1Morsift1Mas dataset to bench on.Results
...