Update cursive 0.20.0 -> 0.21.1#8253
Closed
cfsmp3 wants to merge 1 commit intofacebookincubator:mainfrom
Closed
Conversation
Summary: This is an attempt to update cursive. What started this was a RUSTSEC on a transitive package but it became a bit of rabbit hole. Anyway, this diff (please review, don't just stamp) updates cursive and it's (I think) only client, which is resctl. This update comes with non-trivial breaking changes, in particular: - The View now requires Send + Sync, to allow accessing or moving views between threads. This prevents using Rc/RefCell, and may require using Arc/Mutex instead. This should eventually open the way for more multi-threaded processing of the view tree. Of course this requires changing pretty much everything that touches Views... which is a lot. DevMate did a lot of the work once I got it in the right track. It builds and tests pass. The other thing worth mentioning is that the crate cursive_buffered_backend is removed, because cursive now includes this according its CHANGELOG. - The output to the backend is now buffered and delta-patched, resulting in improved performance for most backends. Reviewed By: Imxset21 Differential Revision: D77703952
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77703952 |
Contributor
|
This pull request has been merged in 51c01fc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This is an attempt to update cursive. What started this was a RUSTSEC on a transitive package but it became a bit of rabbit hole.
Anyway, this diff (please review, don't just stamp) updates cursive and it's (I think) only client, which is resctl.
This update comes with non-trivial breaking changes, in particular:
Of course this requires changing pretty much everything that touches Views... which is a lot.
DevMate did a lot of the work once I got it in the right track. It builds and tests pass.
The other thing worth mentioning is that the crate cursive_buffered_backend is removed, because cursive now includes this according its CHANGELOG.
Reviewed By: Imxset21
Differential Revision: D77703952