break(eslint-plugin): Add ESLint flag configs, require ESLint >= 8.57#12025
Merged
Conversation
slorber
added
pr: new feature
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
✅ [V2]
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Size Change: +5.61 kB (+0.05%) Total Size: 12 MB 📦 View Changed
ℹ️ View Unchanged
|
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: +5.74 kB (+0.05%) Total Size: 12.5 MB 📦 View Changed
ℹ️ View Unchanged
|
slorber
changed the title
>= 8.57
Collaborator
Author
|
The Yarn PnP CI errors are unrelated and seem like an internal Node bug: https://github.com/facebook/docusaurus/actions/runs/25930382253/job/76223499544?pr=12025 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Our ESLint plugin now requires ESLint
>= 8.57.0Motivation
This adds support for ESLint flat config to our ESLint plugin, while preserving the legacy configs and compatibility with ESLint 8.
We'll drop legacy configs and ESLint 8 support in the future, so it's better to migrate to this new format and upgrade to ESLint 9/10+.
Extracted from a larger PR (#12024) so that we can document it separately as a feature + breaking change.
Test Plan
Unfortunately, we don't have a CI setup to test against multiple versions of ESLint atm.
Our monorepo still uses ESLint 8 on this PR, and CI passes, so this shows the compatibility with ESLint 8 is maintained.
The plugin code is the same in the ESLint 9 + flat config upgrade (#12024) which shows the same code works with both ESLint 8/9.
Test link
Docs updated: https://deploy-preview-12025--docusaurus-2.netlify.app/docs/api/misc/@docusaurus/eslint-plugin/