Skip to content

WIP: Stats txns supply#153

Open
hackmod wants to merge 5 commits intoethereumclassic:devfrom
hackmod:stats-txns-supply
Open

WIP: Stats txns supply#153
hackmod wants to merge 5 commits intoethereumclassic:devfrom
hackmod:stats-txns-supply

Conversation

@hackmod
Copy link
Copy Markdown
Contributor

@hackmod hackmod commented Jul 9, 2018 •
edited
Loading

Please do not merge it (WIP)

any suggestions are welcomed

  • Transaction chart
    • fix for speed issue => reduced range, make default range configurable.
  • total supply pie chart (/stats/supply) and normal total supply (/supply) for the coinmarketcap
    • support ECIP1017 (enabled by default.)
    • estimate uncle rewards correctly.

simple URL APIs

  • /supply : returns all info. as a json.
  • /supply/total or /supply/totalSupply : the amount of total supply. (for coinmarketcap)
  • /supply/genesisAlloc : genesis alloc
  • /supply/minerRewards : the amount of all mined block rewards.
  • /supply/uncleRewards: estimated uncle rewards.

Screen shot

image

References

@hackmod hackmod force-pushed the stats-txns-supply branch 2 times, most recently from f6f78ef to 1b82bed Compare July 9, 2018 18:16
@phyro
Copy link
Copy Markdown
Member

phyro commented Jul 9, 2018

If rich list feature is listing the wallets with largest balance, I second that 👍

@hackmod hackmod force-pushed the stats-txns-supply branch 3 times, most recently from 7076ee7 to 5198021 Compare July 10, 2018 06:50
@ethereumclassic ethereumclassic deleted a comment Jul 24, 2018
@ghost
Copy link
Copy Markdown

ghost commented Aug 5, 2018

WTF is this?? var days = config.settings.stats && config.settings.stats.txnDays || 3;

@realcodywburns
Copy link
Copy Markdown
Member

realcodywburns commented Aug 24, 2018

Is this ready to merge?

@hackmod
Copy link
Copy Markdown
Contributor Author

hackmod commented Aug 24, 2018

@realcodywburns // almost ready, except the transaction chart needs some more tuning for speed issue.

@realcodywburns realcodywburns changed the title Stats txns supply WIP Stats txns supply Nov 16, 2018
@realcodywburns realcodywburns changed the title WIP Stats txns supply WIP: Stats txns supply Nov 16, 2018
@hackmod hackmod force-pushed the stats-txns-supply branch 2 times, most recently from bbda824 to 7338151 Compare December 4, 2018 10:03
@hackmod
Copy link
Copy Markdown
Contributor Author

hackmod commented Dec 4, 2018 •
edited
Loading

rebased, fixed travis error. tooltip added.

@hackmod hackmod force-pushed the stats-txns-supply branch from 1898ecf to 641781c Compare March 10, 2019 09:49
ghost
ghost suggested changes Mar 11, 2019
View reviewed changes
Copy link
Copy Markdown

@ghost ghost left a comment •
edited by ghost
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@ghost
Copy link
Copy Markdown

ghost commented Mar 25, 2019

Rebase your PR!

@hackmod hackmod force-pushed the stats-txns-supply branch from 92357b7 to 806c42d Compare October 4, 2019 17:53
@hackmod
Copy link
Copy Markdown
Contributor Author

hackmod commented Oct 4, 2019 •
edited
Loading

rebased

ready to merge.

@hackmod
Copy link
Copy Markdown
Contributor Author

hackmod commented Jan 14, 2020

rebased again. ready to merge~

@kimisan kimisan self-requested a review January 14, 2020 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kimisan kimisan kimisan approved these changes

+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement work in progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hackmod @phyro @realcodywburns @kimisan