Fix to allow the decode to work with the SkyEcho 2 receiver (port 4000).#6
Open
dimme wants to merge 1 commit intoetdey:masterfrom
Open
Fix to allow the decode to work with the SkyEcho 2 receiver (port 4000).#6dimme wants to merge 1 commit intoetdey:masterfrom
dimme wants to merge 1 commit intoetdey:masterfrom
Conversation
dimme
commented
Jul 28, 2025
dimme
commented
- Remove strict 12-byte length assertion for Skyradar GPS time messages
- Add format validation to check for expected Skyradar format (byte[1] == 0x2A)
- Implement graceful handling of unknown message 101 formats
- Add bounds checking and time validation to prevent crashes
- Allow decoder to continue processing other messages when MSG101 format is unknown
- Remove strict 12-byte length assertion for Skyradar GPS time messages - Add format validation to check for expected Skyradar format (byte[1] == 0x2A) - Implement graceful handling of unknown message 101 formats - Add bounds checking and time validation to prevent crashes - Allow decoder to continue processing other messages when MSG101 format is unknown
etdey
requested changes
Aug 16, 2025
Owner
etdey
left a comment
etdey
left a comment
There was a problem hiding this comment.
While I'm not going to take this PR as-is, I have just incorporated your skipping logic for non-Skyradar 101 messages into my main branch. The code now provides a hook point for handling differently formatted type 101 messages.
Owner
|
Would you mind to grab my latest changes and see if they achieve the results you are looking for? If not, can you post another PR based on my updates? |
Author
|
Hi there. Cannot verify atm, but I will comment here as soon as I do. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.