fix: typeScript compilation error and test failures in pnpm support#1659
Merged
neilime merged 3 commits intofeat/supports-pnpmfrom Nov 7, 2025
Merged
fix: typeScript compilation error and test failures in pnpm support#1659neilime merged 3 commits intofeat/supports-pnpmfrom
neilime merged 3 commits intofeat/supports-pnpmfrom
Conversation
Co-authored-by: neilime <[email protected]>
Co-authored-by: neilime <[email protected]>
Copilot
AI
changed the title
[WIP] Fix build and make tests pass for pnpm support
Fix TypeScript compilation error and test failures in pnpm support
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses build and test failures preventing pnpm support from merging.
Changes
PackageManagerService.isPackageInstalled(): Changedconst argstolet argsto allow reassignment in pnpm case, which constructs a different argument structure than npm/yarnpackage-lock.jsonin react test fixtures: File existed in core but was absent in react, causing test failuresExample
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.