Fix benchmark comparison table rendering#1399
Conversation
cat() defaults to joining with a single space, so knitr::kable() output was emitted as one line. Use sep = "\n" so each table row stays on its own line. Co-authored-by: sbfnk <sebastian.funk@lshtm.ac.uk>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe benchmark comparison script's Markdown report output is adjusted to include a separator parameter in the ChangesBenchmark Report Output Formatting
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
minor workflow change, all fine |
Description
This PR closes #1398.
knitr::kable()returns a character vector with one element per row.cat()was joining those rows with its default single-space separator, so the markdown table came out as a single long line and rendered as plain text in the benchmark comment (see the table in #1396 (comment)). Passingsep = "\n"puts each row on its own line so GitHub renders it as a table.Initial submission checklist
devtools::test()anddevtools::check()).devtools::document()).lintr::lint_package()).The change is to a developer-only script under
inst/dev/that is used by CI to post benchmark comments on PRs — it is not user-facing, so no NEWS item and no unit tests.Summary by CodeRabbit