Wrap as_forecast_sample example in \donttest{}#1384
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughThis PR wraps the long-running ChangesDocumentation Example Wrapping
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seabbs
left a comment
There was a problem hiding this comment.
We changed this in review but I think it actually breaks package convention and leads to a long running example. Note we likely need an issue for storing a few fits as epinowcast does so our examples can all be running (or a shared script that pkgdown runs or something if that is now possible)
Description
This PR closes #1383.
The example for
as_forecast_sample()(added in #1367) callsestimate_infections()directly, which fits a Stan model.R CMD checkreports it taking ~37s of CPU/elapsed time:Other Stan-fitting examples in the package (
estimate_infections,epinow,forecast_secondary,estimate_truncation) wrap the fit in\donttest{}. This PR matches that convention.Initial submission checklist
devtools::test()anddevtools::check()).devtools::document()).lintr::lint_package()).This was opened by a bot. Please ping @seabbs for any questions.
Summary by CodeRabbit
Bug Fixes
Documentation