Update to emscripten-core/emscripten#26860#7
Conversation
| @@ -1 +1,3 @@ | |||
| #define PAGE_SIZE 65536 | |||
| // A value used historically in Emscripten, and which we don't have a strong | |||
| // reason to change so far. | |||
There was a problem hiding this comment.
This is the defined WebAssembly page size, so it kind of makes sense. i.e. its not just historical.
There was a problem hiding this comment.
I'll remove this comment. It looks that I synced this with getpagesize() before commit emscripten-core/emscripten@0494e29 was introduced.
There was a problem hiding this comment.
Removed with commit emscripten-core/emscripten@a62785a (and updated this PR accordingly).
|
|
||
| _Noreturn void exit(int code) | ||
| { | ||
| #ifdef _REENTRANT // XXX Emscripten: guard with _REENTRANT |
There was a problem hiding this comment.
To fix a test failure in other.test_standalone_whole_archive:
wasm-ld: error: --shared-memory is disallowed by exit.o because it was not compiled with 'atomics' or 'bulk-memory' features.
See commit emscripten-core/emscripten@3d7b8f3.
There was a problem hiding this comment.
Maybe a better fix for that would be to make libstandalonewasm into an MTLibrary?
There was a problem hiding this comment.
Ah, I thought it was a --whole-archive quirk, but you're right, we can simply make libstandalonewasm inherit from MTLibrary to fix this.
Fixed via commit emscripten-core/emscripten@abfd52c and emscripten-core/emscripten@0f0d7c0.
kleisauke
force-pushed
the
update-to-pr-26860
branch
from
9600075 to
a132375
Compare
This change was generated by running ./system/lib/push_musl_changes.py within the Emscripten repo.
kleisauke
force-pushed
the
update-to-pr-26860
branch
from
a132375 to
0403aee
Compare
2 participants
This change was generated by running ./system/lib/push_musl_changes.py
within the Emscripten repo.