fix: guard against transient visualViewport height glitches#636
Open
woobottle wants to merge 1 commit intoemilkowalski:mainfrom
Open
fix: guard against transient visualViewport height glitches#636woobottle wants to merge 1 commit intoemilkowalski:mainfrom
woobottle wants to merge 1 commit intoemilkowalski:mainfrom
Conversation
Avoid using 0/invalid or extremely small visualViewport height values in keyboard-related drawer resizing on iOS/WKWebView by falling back to the last known good measurement.
|
Lifesaver! Thank you so much! |
|
Hope this get's merged and released. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: On iOS/WKWebView, visualViewport.height can transiently report 0/very small values during UI transitions. Vaul’s keyboard/viewport resize logic uses this value to compute diffFromInitial, which can spike and cause incorrect bottom/height adjustments, pushing the drawer off-screen.
Fix: Ignore invalid/implausibly small visualViewport.height readings and fall back to the last known good value (or window.innerHeight as a final fallback). Clamp computed heights to avoid negative values in fixed mode.