feat: blink.pairs support#419
Conversation
📝 WalkthroughWalkthroughAdds public highlight mappings for BlinkPairs (7 colors) and BlinkIndent (several colors) to Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@lua/gruvbox.lua`:
- Around line 561-567: The highlight group is misnamed: replace the
BlinkPairsViolet entry with BlinkPairsPurple so it matches blink.pairs
expectations; locate the table entries where BlinkPairsViolet is defined
(alongside BlinkPairsRed, BlinkPairsOrange, BlinkPairsYellow, BlinkPairsGreen,
BlinkPairsBlue, BlinkPairsCyan) and rename the key BlinkPairsViolet to
BlinkPairsPurple to restore the plugin's default rainbow depth-based
highlighting.
There was a problem hiding this comment.
🧹 Nitpick comments (1)
lua/gruvbox.lua (1)
561-567: BlinkPairs highlight groups implementation is correct and follows all conventions.The seven highlight groups (Red, Orange, Yellow, Green, Blue, Cyan, Purple) correctly follow the plugin prefix naming convention and link to base Gruvbox* groups that handle light/dark backgrounds automatically. The previous
BlinkPairsViolet→BlinkPairsPurplefix is confirmed.Consider adding
BlinkPairsUnmatchedto complete blink.pairs coverage. This group is used by default for unmatched/mismatched bracket pairs. Without it, users would need to manually configure this highlighting.Optional addition for unmatched pairs
BlinkPairsPurple = { link = "GruvboxPurple" }, + BlinkPairsUnmatched = { link = "GruvboxRed" }, BlinkIndentRed = { link = "GruvboxRed" },Code formatting complies with stylua requirements.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@lua/gruvbox.lua` around lines 561 - 567, Add a BlinkPairsUnmatched highlight group to mirror the other BlinkPairs entries so unmatched/mismatched bracket pairs are styled by the theme; update the list in gruvbox.lua alongside BlinkPairsRed/Orange/Yellow/Green/Blue/Cyan/Purple by adding BlinkPairsUnmatched and link it to an appropriate Gruvbox group (e.g., "GruvboxRed") so it follows the same light/dark handling as the others.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@lua/gruvbox.lua`:
- Around line 561-567: Add a BlinkPairsUnmatched highlight group to mirror the
other BlinkPairs entries so unmatched/mismatched bracket pairs are styled by the
theme; update the list in gruvbox.lua alongside
BlinkPairsRed/Orange/Yellow/Green/Blue/Cyan/Purple by adding BlinkPairsUnmatched
and link it to an appropriate Gruvbox group (e.g., "GruvboxRed") so it follows
the same light/dark handling as the others.
Summary by CodeRabbit