Skip to content

feat: blink.pairs support#419

Merged
ellisonleao merged 3 commits intoellisonleao:mainfrom
Kaiser-Yang:main
Mar 9, 2026
Merged

feat: blink.pairs support#419
ellisonleao merged 3 commits intoellisonleao:mainfrom
Kaiser-Yang:main

Conversation

@Kaiser-Yang
Copy link
Copy Markdown
Contributor

@Kaiser-Yang Kaiser-Yang commented Feb 20, 2026

Summary by CodeRabbit

  • New Features
    • Extended Gruvbox theme with added highlight groups for blink pair matching and blink indentation guides, now available in red, orange, yellow, green, blue, cyan (aqua), and purple/violet variants.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Feb 20, 2026

📝 Walkthrough

Walkthrough

Adds public highlight mappings for BlinkPairs (7 colors) and BlinkIndent (several colors) to lua/gruvbox.lua, linking each new group to existing Gruvbox color tokens; no control flow or other logic changes.

Changes

Cohort / File(s) Summary
Gruvbox blink highlight groups
lua/gruvbox.lua
Added BlinkPairs{Red, Orange, Yellow, Green, Blue, Cyan, Purple} linked to Gruvbox{Red,Orange,Yellow,Green,Blue,Aqua,Purple} and added BlinkIndent mappings (Green, Blue, Cyan, Violet) linked to corresponding Gruvbox tokens.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • feat: blink.indent support #418: Adds BlinkIndent highlight group mappings in the same lua/gruvbox.lua file, closely related to these blink-related highlight additions.

Poem

🐰
Colors hop in tiny arcs and cheer,
Blink pairs shimmer, bright and clear,
Indents glow in verdant light,
Gruvbox paints the code at night,
A rabbit claps — the hues delight! 🥕✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'feat: blink.pairs support' accurately describes the main change: adding highlight group mappings for blink.pairs UI elements to the Gruvbox theme.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@lua/gruvbox.lua`:
- Around line 561-567: The highlight group is misnamed: replace the
BlinkPairsViolet entry with BlinkPairsPurple so it matches blink.pairs
expectations; locate the table entries where BlinkPairsViolet is defined
(alongside BlinkPairsRed, BlinkPairsOrange, BlinkPairsYellow, BlinkPairsGreen,
BlinkPairsBlue, BlinkPairsCyan) and rename the key BlinkPairsViolet to
BlinkPairsPurple to restore the plugin's default rainbow depth-based
highlighting.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
lua/gruvbox.lua (1)

561-567: BlinkPairs highlight groups implementation is correct and follows all conventions.

The seven highlight groups (Red, Orange, Yellow, Green, Blue, Cyan, Purple) correctly follow the plugin prefix naming convention and link to base Gruvbox* groups that handle light/dark backgrounds automatically. The previous BlinkPairsVioletBlinkPairsPurple fix is confirmed.

Consider adding BlinkPairsUnmatched to complete blink.pairs coverage. This group is used by default for unmatched/mismatched bracket pairs. Without it, users would need to manually configure this highlighting.

Optional addition for unmatched pairs
     BlinkPairsPurple = { link = "GruvboxPurple" },
+    BlinkPairsUnmatched = { link = "GruvboxRed" },
     BlinkIndentRed = { link = "GruvboxRed" },

Code formatting complies with stylua requirements.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@lua/gruvbox.lua` around lines 561 - 567, Add a BlinkPairsUnmatched highlight
group to mirror the other BlinkPairs entries so unmatched/mismatched bracket
pairs are styled by the theme; update the list in gruvbox.lua alongside
BlinkPairsRed/Orange/Yellow/Green/Blue/Cyan/Purple by adding BlinkPairsUnmatched
and link it to an appropriate Gruvbox group (e.g., "GruvboxRed") so it follows
the same light/dark handling as the others.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@lua/gruvbox.lua`:
- Around line 561-567: Add a BlinkPairsUnmatched highlight group to mirror the
other BlinkPairs entries so unmatched/mismatched bracket pairs are styled by the
theme; update the list in gruvbox.lua alongside
BlinkPairsRed/Orange/Yellow/Green/Blue/Cyan/Purple by adding BlinkPairsUnmatched
and link it to an appropriate Gruvbox group (e.g., "GruvboxRed") so it follows
the same light/dark handling as the others.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a100e4f6-66cf-4d8a-80b9-54c8875a3514

📥 Commits

Reviewing files that changed from the base of the PR and between d3d3802 and bea04a9.

📒 Files selected for processing (1)
  • lua/gruvbox.lua

@ellisonleao ellisonleao merged commit a2d3d26 into ellisonleao:main Mar 9, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants