Skip to content

fix(recover): wrap embedded-manifest atob in try/catch for corrupt base64 #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eljojo merged 1 commit into from
Apr 17, 2026
Merged

fix(recover): wrap embedded-manifest atob in try/catch for corrupt base64 #154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 20 additions & 6 deletions internal/html/assets/src/app.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,13 +341,27 @@ type UIShare = ParsedShare & { isHolder?: boolean };

// Load embedded manifest if available (included when MANIFEST.age is small enough)
if (personalization.manifestB64) {
const binary = atob(personalization.manifestB64);
const bytes = new Uint8Array(binary.length);
for (let i = 0; i < binary.length; i++) {
bytes[i] = binary.charCodeAt(i);
try {
const binary = atob(personalization.manifestB64);
const bytes = new Uint8Array(binary.length);
for (let i = 0; i < binary.length; i++) {
bytes[i] = binary.charCodeAt(i);
}
state.manifest = bytes;
showManifestLoaded('MANIFEST.age', state.manifest.length, 'embedded');
} catch (err) {
// atob throws DOMException on corrupt base64 (bit rot, truncated copy,
// storage degradation). Surface it so the user knows to try another
// copy of recover.html rather than assuming they need MANIFEST.age
// separately.
showError(
t('error_corrupt_embedded_manifest_message'),
{
title: t('error_corrupt_embedded_manifest_title'),
guidance: t('error_corrupt_embedded_manifest_guidance'),
}
);
}
state.manifest = bytes;
showManifestLoaded('MANIFEST.age', state.manifest.length, 'embedded');
}

checkRecoverReady();
Expand Down
3 changes: 3 additions & 0 deletions internal/translations/recover/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,9 @@
"error_extract_status": "Extraction failed. The archive may be corrupted.",
"error_recovery_title": "Recovery failed",
"error_recovery_guidance": "Check that you have the correct pieces and the right MANIFEST.age file. You can try again with different pieces.",
"error_corrupt_embedded_manifest_title": "Corrupted embedded archive",
"error_corrupt_embedded_manifest_message": "The archive embedded in this recover.html is damaged and couldn't be loaded.",
"error_corrupt_embedded_manifest_guidance": "Your copy of recover.html may be truncated or corrupted. Try another copy of the file, or load MANIFEST.age manually in Step 2.",
"action_reload": "Reload page",
"action_use_cli": "Use CLI tool",
"action_try_different_shares": "Try different pieces",
Expand Down
Loading