Skip to content

Fix/improved turkish bip39 wordlist#149

Merged
eljojo merged 2 commits intoeljojo:mainfrom
FrustT:fix/improved-turkish-bip39-wordlist
Apr 7, 2026
Merged

Fix/improved turkish bip39 wordlist#149
eljojo merged 2 commits intoeljojo:mainfrom
FrustT:fix/improved-turkish-bip39-wordlist

Conversation

@FrustT
Copy link
Copy Markdown

@FrustT FrustT commented Apr 7, 2026

Greetings,
hope you are doing well

What this changes

After The Initial PR i have found a couple of rude words in the wordlist that i generated.
While substituting rude words i have also changed the other words that lost its meaning while converting non-ASCII chars in the Turkish Alphabet to ASCII chars (ş -> s , ü -> u)

Also , substituted some archaic words with words in the daily life

How I tested this

Ran make test make test-e2e make full make serve

Checklist

  • I have read CONTRIBUTING.md and this PR follows the guidelines
  • A human has reviewed the entire diff of this PR, every line of code
  • A human understands the changes and can explain why this approach is correct
  • Tests pass (make full)
  • This PR doesn't have AI-generated boilerplate or co-author lines
  • This PR was authored and submitted by an AI agent without human review

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 7, 2026

Worth a look

Unchecked items in the PR checklist

Each checkbox is an attestation — please fill them in honestly. If one doesn't apply to your change, note why in the description.

Copy link
Copy Markdown
Owner

@eljojo eljojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a very thoughtful change, thanks for bringing it up!

@eljojo eljojo merged commit 7991277 into eljojo:main Apr 7, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants