Skip to content

Provide bare and opt set operations#15433

Open
josevalim wants to merge 7 commits into
mainfrom
jv-opt-descr
Open

Provide bare and opt set operations#15433
josevalim wants to merge 7 commits into
mainfrom
jv-opt-descr

Conversation

@josevalim
Copy link
Copy Markdown
Member

This pull request breaks set operations (union, intersections, differences, and negations) into bare and opt (optimized). This is a large PR but most changes are mechanical:

  • All functions outside of the Descr module use the optimized versions
  • The Descr module uses the bare versions for everything, except for to_quoted and type "mutators" (tuple_update, map_delete, etc)

Therefore, to review this code, it is best to open up the descr.ex module and see if the usage of opt_* functions within that module are acceptable. There are not many of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant