support select-merging into a source within a subquery#4680
Closed
zachdaniel wants to merge 2 commits intoelixir-ecto:masterfrom
Closed
support select-merging into a source within a subquery#4680zachdaniel wants to merge 2 commits intoelixir-ecto:masterfrom
zachdaniel wants to merge 2 commits intoelixir-ecto:masterfrom
Conversation
This was referenced Nov 15, 2025
Closed
zachdaniel
commented
Nov 15, 2025
| defp classify_merge({:merge, _, [{:&, meta, [ix]} | _rest]}, take) do | ||
| case take do | ||
| %{^ix => {:map, _}} -> {:map, meta, :runtime} | ||
| _ -> {:source_with_extra, meta, ix} |
Contributor
Author
There was a problem hiding this comment.
The assumption here is that any required validations on those extra fields would have been done in the original select_merge that produces this. So this is just telling us what the original source was.
Member
|
Apologies but I am not feeling very confident with those changes. It seems we are only asking for more corner cases to be added further down the road. If we are going to support merge, then we need to investigate all possible combinations right now. Merge with sources, schemas, structs, maps, etc. |
Contributor
Author
|
I was about to push back but I think I may just be misunderstanding the problem I'm trying to solve regardless, will revisit later 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example test is a bit goofy but it is a result of me paring down a more complex operation from the AshPostgres query builder. Hopefully it makes sense 😄.
Open to improving the test and/or the actual fix itself.