Conversation
malept
left a comment
There was a problem hiding this comment.
I would prefer not to change the minimum Node version supported just for the sake of changing it, even if Node 10 is EOL.
|
The reason why I decided to submit this was the bump in some of our dependencies which now require node 12+. We don't have to update our dependencies, but I thought it'll be good to keep updating them since there are usually bug/vulnerability fixes when there's a new release. Right now #193 and #194 are blocked because of this. |
|
Also, this problem is happening in all @malept what is your suggestion for keeping dependencies updated and not dropping support for node 10? |
|
Here is an example of what I would prefer to see: malept/flatpak-bundler#33 Eventually I'd like to have some sort of semantic-release on these installer packages, so having multiple PRs which trigger multiple releases is not ideal. |
|
@malept I see what you mean, you want to combine the bumping of version and removing of node 10 support into a single PR. I was just thinking of keeping them separate just to keep a cleaner commit log but it makes total sense. |
|
I am all for keeping the commits in the branch separate (makes reading the PR easier) but I'm less concerned about the commits in the default branch. |
This will close #193, close #194, and close #197