feat!: adopt standard-user/shopper-roles in custom-api-role-policies#92
Open
ellanan wants to merge 1 commit into
Open
feat!: adopt standard-user/shopper-roles in custom-api-role-policies#92ellanan wants to merge 1 commit into
ellanan wants to merge 1 commit into
Conversation
BREAKING CHANGE: removes GetBuiltInRoles and BuiltInRolePolicy. Replace with GetStandardUserRoles + GetStandardShopperRoles. CustomApiRolePolicy now uses standard_user_role / standard_shopper_role on relationships.role.data.type (was built_in_role). GetCustomApiRolePolicies accepts an `include: 'role'` argument and its return type changes from Promise<Resource<Array<CustomApiRolePolicy>>> to Promise<CustomApiRolePoliciesResponse>, which adds optional `included.role` inline. Runtime shape is compatible, but downstream typings referencing the old return type will need updating.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: removes GetBuiltInRoles and BuiltInRolePolicy. Replace with GetStandardUserRoles + GetStandardShopperRoles. CustomApiRolePolicy now uses standard_user_role / standard_shopper_role on relationships.role.data.type (was built_in_role).
GetCustomApiRolePolicies accepts an
include: 'role'argument and its return type changes from Promise<Resource<Array>> to Promise, which adds optionalincluded.roleinline. Runtime shape is compatible, but downstream typings referencing the old return type will need updating.Type
Feature
Implements a new featureFix
Fixes a bugDocs
Documentation only changesStyle
Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)Refactor
A code change that neither fixes a bug nor adds a featurePerformance
A code change that improves performanceTest
Adding missing or correcting existing testsChore
Changes to the build process or auxiliary tools and libraries such as documentation generationDescription
A brief description of the goals of the pull request.
Dependencies
Other PRs or builds that this PR depends on.
Issues
A list of issues closed by this PR.
Notes
Any additional notes.