[9.3] [Cases]Fix All Cases view phrase search (#266827)#268552
Open
christineweng wants to merge 1 commit intoelastic:9.3from
Open
[9.3] [Cases]Fix All Cases view phrase search (#266827)#268552christineweng wants to merge 1 commit intoelastic:9.3from
christineweng wants to merge 1 commit intoelastic:9.3from
Conversation
## Summary Ref: elastic#266825 This PR restores phrase-search behavior in the All Cases search bar that regressed after elastic#245321 switched the cases search path from `simple_query_string` (via SO `find`) to `multi_match`. **After** `test case` (without quotes) matches cases with word `test` or `case` <img width="1033" height="253" alt="image" src="https://github.com/user-attachments/assets/d3c9cb2f-69b7-4406-83c3-4f806399a56e" /> `"test case"` matches cases with phrase `test case` <img width="1020" height="192" alt="image" src="https://github.com/user-attachments/assets/308ef4d9-b1b8-4091-9325-7cfc59224a73" /> ## How to test 1. Create a few cases with titles like `my awesome case`, `another case`, `awesome work`. 2. In the All Cases page, search for `"awesome case"` (with quotes) and confirm only `my awesome case` matches. 3. Add a comment containing `connection refused` to one case, then search `"connection refused"` and confirm only that case matches. 4. Confirm unquoted multi-token search (`awesome case`) still returns OR-style results, matching pre-elastic#245321 behavior. ### Checklist - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. (cherry picked from commit 4168343) # Conflicts: # x-pack/platform/plugins/shared/cases/server/services/cases/utils.test.ts
8 tasks
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.3:Questions ?
Please refer to the Backport tool documentation