fix(mockotlpserver): validate dynamic action names and guard calls#1134
Open
odaysec wants to merge 1 commit intoelastic:mainfrom
Open
fix(mockotlpserver): validate dynamic action names and guard calls#1134odaysec wants to merge 1 commit intoelastic:mainfrom
odaysec wants to merge 1 commit intoelastic:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix for #1133
To prevent security or runtime issues from unvalidated dynamic method lookup, we should ensure that:
parsersMap(not from the prototype chain).parsersMapis a function before invoking it.This can be addressed by replacing the direct dynamic call to
parsersMap[contentType], and ensuring with two checks:.hasOwnProperty(contentType)to confirm it is an own property,typeof parsersMap[contentType] === 'function'to confirm it resolves to a function.Alternatively, if
parsersMapis never reassigned, it would be even safer to create it as an object without a prototype (e.g.,Object.create(null)) or as aMap(but we cannot edit that from the current context). The best minimal fix given the context is to update the code inside the'end'handler function, from the assignment and use ofparseData, to ensure these checks are made before callingparseData. If validation fails, we can fall back tounknownParseras it currently does.