Move the bootstrap checks from system config to settings config#6383
Open
yetanothertw wants to merge 3 commits intomainfrom
Open
Move the bootstrap checks from system config to settings config#6383yetanothertw wants to merge 3 commits intomainfrom
yetanothertw wants to merge 3 commits intomainfrom
Conversation
Contributor
Elastic Docs AI PR menuCheck the box to run an AI review for this pull request.
Powered by GitHub Agentic Workflows and docs-actions. For more information, reach out to the docs team. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3140
Added a Bootstrap checks item at the top of the Important settings configuration page. I've included a short explanation that checks cover ES/JVM and OS limits, with links to Bootstrap checks and Important system configuration (host limits).
Updated the Important system configuration to remove the bootstraps section and replaced it with an admonition right after the checklist because I wanted to preserve some of the context that explains that OS limits can often fail checks in prod mode.
Note to the reviewer
The build is failing because of a link that needs to updated in elastic/elasticsearch#148641 which can only be merged once this PR has been merged and created that new link. It's kind of a chicken and egg situation, so you might need to build locally to review.
Generative AI disclosure
Yes, I used Claude in Auto mode to find relevant links that needed updating.