Open
Conversation
Contributor
Rule: Tuning - GuidelinesThese guidelines serve as a reminder set of considerations when tuning an existing rule. Documentation and Context
Rule Metadata Checks
Testing and Validation
|
|
⛔️ Test failed Results
|
|
⛔️ Test failed Results
|
|
⛔️ Test failed Results
|
| query = ''' | ||
| FROM logs-endpoint.events.process-* METADATA _id, _index, _version, _ignored | ||
| | MV_EXPAND _ignored | ||
| | MV_EXPAND event.type |
Contributor
There was a problem hiding this comment.
Why MV_EXPAND? Can we just KQL wrap it like we did for the other rules?
Contributor
Author
There was a problem hiding this comment.
KQL() is not allowed after MV_EXPAND, and because we need to use MV_EXPAND on _ignored, this seemed to be the logical approach.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
There is a "feature" where using ES|QL to search a list using the
==orinoperators, will returnnull. For example, searching theevent.actionlist[exec, fork, end]by searchingevent.action == "exec"will result innull, effectively making the query hit a FN.This PR fixes this, by either using the
KQL()function where possible or usingmv_expandwhere theKQL()function is not possible (e.g.KQLafter anEVALis unsupported).