MITRE ATT&CK v19.0.0#6037
Draft
shashank-elastic wants to merge 4 commits intomainfrom
Draft
Conversation
Contributor
Enhancement - GuidelinesThese guidelines serve as a reminder set of considerations when addressing adding a feature to the code. Documentation and Context
Code Standards and Practices
Testing
Additional Checks
|
3 tasks
|
⛔️ Test failed Results
|
|
⛔️ Test failed Results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue link(s): #6035
Summary - What I changed
attack migrate-retired-tacticsto handle MITRE enterprise tactic name changes (renames, splits, multi-phase techniques) is handled predictably.Changes details
Principles used
Conceptual flow
-- Prefer matrix bucket matching tactic.id when that technique still lists under it.
-- Else apply secondary tactic names from definitions for that TA (e.g. Defense Impairment for TA0005).
-- Else lowest TAxxxx among MITRE ATT&CK data candidates.
How filename changes are handled
How To Test
migrate-retired-tactics dry-run
migrate-retired-tactics-dryrun.txt
migrate-retired-tactics
migrate-retired-tactics.txt
update-rules after migrate is the usual “second sweep” so nothing is left half-updated.
Try 1
When sub-technique
LLMNR/NBT-NS Poisoning and SMB Relaywas renamed toName Resolution Poisoning and SMB RelayTry 2
Checklist
bug,enhancement,schema,maintenance,Rule: New,Rule: Deprecation,Rule: Tuning,Hunt: New, orHunt: Tuningso guidelines can be generatedmeta:rapid-mergelabel if planning to merge within 24 hoursContributor checklist