otel: add cert reload to beatsauthextension#50576
otel: add cert reload to beatsauthextension#50576mauri870 wants to merge 4 commits intoelastic:mainfrom
Conversation
🤖 GitHub commentsJust comment with:
|
da97006 to
7086dad
Compare
This comment has been minimized.
This comment has been minimized.
TL;DRThe Buildkite failure in Remediation
Investigation detailsRoot CauseThe failing code path is in reload := &beatAuthConfig.Transport.TLS.CertificateReload
if reload.Enabled == nil && alias.Enabled != nil {
reload.Enabled = alias.Enabled
}
if reload.ReloadInterval == 0 && alias.Period > 0 {
reload.ReloadInterval = alias.Period
}The Buildkite compiler error is: This matches the dependency mismatch:
Evidence
Verification
Follow-upIf you want to preserve backward compatibility across dependency graphs, the safest fix is to avoid direct compile-time references to newly added struct fields in extension code that may be built outside the Beats root module. Note 🔒 Integrity filter blocked 2 itemsThe following items were blocked because they don't meet the GitHub integrity level.
To allow these resources, lower tools:
github:
min-integrity: approved # merged | approved | unapproved | noneWhat is this? | From workflow: PR Buildkite Detective Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. |
Proposed commit message
The beatsauthextension did not support hot-reloading of TLS certificates. In upstream tlscommon, elastic/elastic-agent-libs#419 implements dynamic reloading whenever a certificate changes on disk. This means that this behavior is now inherited by the extension automatically. Write tests to ensure that hot reloading works. Also, alias the config option
ssl.restart_on_cert_changeto the newssl.certificate_reloadand add a deprecation note for the former.Checklist
stresstest.shscript to run them under stress conditions and race detector to verify their stability../changelog/fragmentsusing the changelog tool.Disruptive User Impact
How to test this PR locally
Related issues