Docs: Deprecate Elasticsearch output options not available for Beat receivers#50543
Docs: Deprecate Elasticsearch output options not available for Beat receivers#50543vishaangelova wants to merge 6 commits intomainfrom
Conversation
🤖 GitHub commentsJust comment with:
|
|
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (5)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughHidden review stack artifactWalkthroughThis PR updates Elasticsearch output reference docs for Auditbeat, Filebeat, Heartbeat, Metricbeat, Packetbeat, and Winlogbeat. It adds 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/reference/auditbeat/elasticsearch-output.md`:
- Line 483: The docs-content://...#beat-receivers anchor used in the note at the
top of the Elasticsearch output docs fails redirect-anchor resolution; replace
the problematic target
(docs-content://reference/fleet/elastic-agent-as-otel-collector.md#beat-receivers)
with a stable, resolvable link/anchor (for example the target page without the
docs-content:// scheme plus the correct section anchor or the canonical relative
path and anchor that the site build recognizes) and update the identical note in
the other modified Beat docs files in this PR to use the same resolvable
link/anchor so all instances resolve cleanly during the docs build.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Enterprise
Run ID: 8ffe358b-63de-48e0-8c4f-bfcaa72b8d78
📒 Files selected for processing (6)
docs/reference/auditbeat/elasticsearch-output.mddocs/reference/filebeat/elasticsearch-output.mddocs/reference/heartbeat/elasticsearch-output.mddocs/reference/metricbeat/elasticsearch-output.mddocs/reference/packetbeat/elasticsearch-output.mddocs/reference/winlogbeat/elasticsearch-output.md
🔍 Preview links for changed docs |
Vale Linting ResultsSummary: 18 suggestions found 💡 Suggestions (18)
The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale. |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
docs/reference/heartbeat/elasticsearch-output.md (1)
293-376:⚠️ Potential issue | 🔴 Critical | ⚡ Quick winMissing deprecation notices for
pipelineandpipelinesoptions.PR objectives state that both
pipelineandpipelinesshould be deprecated, but neither section has the required{applies_to}deprecation block added. These options need deprecation metadata consistent with the other deprecated options.Expected additions:
- After line 293 header, add deprecation block for
pipeline- After line 328 header, add deprecation block for
pipelines📝 Proposed fix
For
pipelinesection (after line 293):### `pipeline` [pipeline-option-es] +```{applies_to} +stack: deprecated 9.5.0+ +``` + A format string value that specifies the ingest pipeline to write events to.For
pipelinessection (after line 328):### `pipelines` [pipelines-option-es] +```{applies_to} +stack: deprecated 9.5.0+ +``` + An array of pipeline selector rules. Each rule specifies the ingest pipeline to use for events that match the rule.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/reference/heartbeat/elasticsearch-output.md` around lines 293 - 376, Add the missing deprecation metadata blocks for the pipeline and pipelines options: insert an {applies_to} deprecation block after the "pipeline" header (the "pipeline" option section) indicating "stack: deprecated 9.5.0+" and a short quoted description, and likewise insert an {applies_to} deprecation block after the "pipelines" header (the "pipelines" option section) with the same "stack: deprecated 9.5.0+" metadata and a short quoted description; ensure the blocks follow the same formatting style used for other deprecated options in the docs so the pipeline and pipelines sections include the required deprecation notices.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@docs/reference/heartbeat/elasticsearch-output.md`:
- Around line 293-376: Add the missing deprecation metadata blocks for the
pipeline and pipelines options: insert an {applies_to} deprecation block after
the "pipeline" header (the "pipeline" option section) indicating "stack:
deprecated 9.5.0+" and a short quoted description, and likewise insert an
{applies_to} deprecation block after the "pipelines" header (the "pipelines"
option section) with the same "stack: deprecated 9.5.0+" metadata and a short
quoted description; ensure the blocks follow the same formatting style used for
other deprecated options in the docs so the pipeline and pipelines sections
include the required deprecation notices.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Enterprise
Run ID: fceb2a0c-c8ac-442f-a22a-c184d0eb12e4
📒 Files selected for processing (6)
docs/reference/auditbeat/elasticsearch-output.mddocs/reference/filebeat/elasticsearch-output.mddocs/reference/heartbeat/elasticsearch-output.mddocs/reference/metricbeat/elasticsearch-output.mddocs/reference/packetbeat/elasticsearch-output.mddocs/reference/winlogbeat/elasticsearch-output.md
🚧 Files skipped from review as they are similar to previous changes (5)
- docs/reference/filebeat/elasticsearch-output.md
- docs/reference/winlogbeat/elasticsearch-output.md
- docs/reference/metricbeat/elasticsearch-output.md
- docs/reference/packetbeat/elasticsearch-output.md
- docs/reference/auditbeat/elasticsearch-output.md
|
LGTM, pinging @nimarezainia for a PM review since this is marking settings as deprecated. |
|
@cmacknz I think marking this as pending deprecation is ok. but I am wondering what we will do with customers who were using these settings (I have no way of determining that). also these docs are changing the beats docs (which unfortunately have always been pointed to by the Elastic Agent output section). These fields are not being deprecated for beats. Only affects beatsreceivers. |
Dead letter index should be deprecated anyway, there's a way to handle this natively in ES now. Deprecating this is overdue, it never came out of beta. I would also agree, we are only deprecating escape_html and allow_older_versions in Elastic Agent since it will use beats receivers going forward. We probably should only deprecate them in the Elastic Agent documentation to start. |
Proposed commit message
This PR deprecates the
escape_html,allow_older_versions, andnon_indexable_policy.dead_letter_indexES output options starting from 9.5+ as these are not applicable/supported when using Beat receivers.Contributes to #47537
Related PR: elastic/docs-content#6217
Checklist
stresstest.shscript to run them under stress conditions and race detector to verify their stability../changelog/fragmentsusing the changelog tool.Preview