Filestream Take over fallback integration tests#50487
Filestream Take over fallback integration tests#50487belimawr wants to merge 25 commits intoelastic:mainfrom
Conversation
GenAI-Assisted: Yes Human-Reviewed: Yes Tool: Cursor-CLI, Model: Codex 5.3 Medium
GenAI-Assisted: Yes Human-Reviewed: Yes Tool: Cursor-CLI, Model: Codex 5.3 Medium
GenAI-Assisted: Yes Human-Reviewed: Yes Tool: Cursor-CLI, Model: Codex 5.3 Medium
GenAI-Assisted: Yes Human-Reviewed: Yes Tool: Cursor-CLI, Model: Codex 5.3 Medium
GenAI-Assisted: Yes Human-Reviewed: Yes Tool: Cursor-CLI, Model: Codex 5.3 Medium
GenAI-Assisted: Yes Human-Reviewed: Yes Tool: Cursor-CLI, Model: Codex 5.3 Medium
GenAI-Assisted: Yes Human-Reviewed: Yes Tool: Cursor-CLI, Model: Codex 5.3 Medium
GenAI-Assisted: Yes Human-Reviewed: Yes Tool: Cursor-CLI, Model: Codex 5.3 Medium
belimawr
added
backport-skip
botelastic
Bot
added
needs_team
🤖 GitHub commentsJust comment with:
|
This comment has been minimized.
This comment has been minimized.
TL;DRAll reproducible failures point to the same Docker image build step for Kerberos in Remediation
Investigation detailsRoot CauseThe three
This command comes from
And the likely failing sub-step in that script is package setup at
Evidence
VerificationNot run locally because this environment does not support Docker-in-Docker; analysis is based on provided Buildkite logs and repository sources. Follow-upIf plain BuildKit output shows a transient apt mirror/network outage, retry is sufficient. If it shows package/repo drift, pin or update package sources in the Kerberos image build scripts. Note 🔒 Integrity filter blocked 2 itemsThe following items were blocked because they don't meet the GitHub integrity level.
To allow these resources, lower tools:
github:
min-integrity: approved # merged | approved | unapproved | noneWhat is this? | From workflow: PR Buildkite Detective Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. |
GenAI-Assisted: Yes Human-Reviewed: Yes Tool: Cursor-CLI, Model: Codex 5.3 Medium
The Registrar needs to flush updates synchronously to the registry, otherwise some states might not be in the registry when Filestream tries to read them. See elastic#50499
…ck-integration-tests
belimawr
added
the
backport-active-9
belimawr
changed the title
We already check evens from every file, no need for a dedicated function just for that.
belimawr
changed the title
GenAI-Assisted: Yes Human-Reviewed: Yes Tool: Cursor-CLI, Model: Codex 5.3 Medium
…ck-integration-tests
belimawr
changed the title
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
📝 WalkthroughWalkthroughThis change introduces infrastructure for integration testing Filebeat's Take Over fallback mechanism between Log and Filestream input types. A new integration test validates the handoff behavior during input reload scenarios, including event deduplication and counter progression verification. Test configuration files define separate input groups with reload settings and templated paths. A data generation utility function is added to support writing log files with custom starting counters, enabling multi-phase test scenarios with sequential event numbering. 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@filebeat/tests/integration/testdata/take-over-fallback/log-input.yml`:
- Line 6: Wrap the template path scalars in quotes to make them valid YAML; e.g.
replace unquoted occurrences like - {{ .logDir }}/group-01-*.log (and similar
lines using {{ .logDir }} in base.yml and filestream-input.yml) with a quoted
scalar '- {{ .logDir }}/group-01-*.log' so the raw template parses/lints
correctly prior to rendering.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Enterprise
Run ID: cda53ce1-b57f-4753-a5aa-5fd8d68592da
📒 Files selected for processing (5)
filebeat/tests/integration/take_over_fallback_test.gofilebeat/tests/integration/testdata/take-over-fallback/base.ymlfilebeat/tests/integration/testdata/take-over-fallback/filestream-input.ymlfilebeat/tests/integration/testdata/take-over-fallback/log-input.ymllibbeat/tests/integration/datagenerator.go
1 participant
Proposed commit message
Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesstresstest.shscript to run them under stress conditions and race detector to verify their stability.I have added an entry in./changelog/fragmentsusing the changelog tool.## Disruptive User ImpactHow to test this PR locally
Run the test
Related issues
## Use cases## Screenshots## Logs