Bugfix: Safely Handle Malformed UAC events#49869
Conversation
🤖 GitHub commentsJust comment with:
|
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
|
Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform) |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe pull request adds defensive error handling to a Windows security ingest pipeline. A changelog fragment documents a bug fix for "Long decoding error" in a Painless script for winlogbeat. The ingest pipeline script is updated with try/catch blocks around Long.decode() calls for both NewUacValue parsing and parameter iteration, allowing the script to continue or return early on decode failures rather than aborting. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
andrewkroh
left a comment
There was a problem hiding this comment.
The pipeline change looks fine.
Note that there is no testing of the pipeline as explained in #49947.
|
@Mergifyio backport 9.3 9.4 |
✅ Backports have been createdDetails
|
* Try to prove the bug via CI * fix painless logic when decoding longs * add changelog fragment * fix typo * PR Feedback * Don't fail silently for explicit params (cherry picked from commit f1bb535) Co-authored-by: Brian McKinney <[email protected]>
* Try to prove the bug via CI * fix painless logic when decoding longs * add changelog fragment * fix typo * PR Feedback * Don't fail silently for explicit params (cherry picked from commit f1bb535) Co-authored-by: Brian McKinney <[email protected]>
Proposed commit message
https://github.com/elastic/sdh-beats/issues/6727
Checklist
stresstest.shscript to run them under stress conditions and race detector to verify their stability../changelog/fragmentsusing the changelog tool.Disruptive User Impact
How to test this PR locally
Related issues
Use cases
Screenshots
Logs