feat(rum-core): allow sending transactions with no spans using config#1665
Merged
david-luna merged 5 commits intomainfrom Dec 4, 2025
Merged
feat(rum-core): allow sending transactions with no spans using config#1665david-luna merged 5 commits intomainfrom
david-luna merged 5 commits intomainfrom
Conversation
🤖 GitHub commentsJust comment with:
|
🔍 Preview links for changed docs |
| * **Type:** Boolean | ||
| * **Default:** `false` | ||
|
|
||
| This allows the agent to send all `route-change` transactions regardless if it contains any spans or not. This is usefull if you want to keep track of all the navigations your app is doing. |
Member
There was a problem hiding this comment.
Need to call out how sampling plays a role in here as well.
| :::: | ||
|
|
||
|
|
||
| ### `sendAllRouteChanges` [send-all-route-changes] |
Member
There was a problem hiding this comment.
There might be a request to add the same logic to user-click events as well, lets make this flag generic? reportAllTraces something along these lines ?
Member
Author
There was a problem hiding this comment.
At 1st I thought maybe to filter by transaction type. I don't have a strong opinion. Do we want a single or more fine grained control?
Member
Author
There was a problem hiding this comment.
My suggestion is recordEmptyTransactions. Empty meaning with no spans. WDYT?
vigneshshanmugam
previously approved these changes
Dec 3, 2025
|
|
||
|
|
||
| ### `sendAllRouteChanges` [send-all-route-changes] | ||
| ### `recordEmptyTransactions` [record-empty-transactions] |
Member
There was a problem hiding this comment.
nit: reportTransactionsWithoutSpans? - fine with Empty as well. Just provided as a suggestion.
david-luna
changed the title
route-change transactions with no spans via config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The route change transaction is a type of transaction that can be interesting eve if it does not contain spans. Can be used to track the journey of the users across the instrumented web application. Is specifically useful for single page applications (SPA) where the URL can change without performing any HTTP request (hence no spans) because of the app caching data or because there is no need to fetch data.
The change introduces a new flag in configuration namedsendAllRouteChangeswhich defaults tofalsekeeping the current behavior. Apps that wants to record all transactions of typeroute-changecan set this config totrue.UPDATE: changed the config options to allow all transactions without spans.
The change introduces a new flag in configuration named
reportTransactionsWithoutSpanswhich defaults tofalsekeeping the current behavior. Apps that wants to record all transactions regardless if they have spans or not can set this config totrue.