acts: backport various fixes for Gen3 in v45.2.0#929
Open
wdconinc wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Backports an ACTS patch into the Spack recipe to fix a Gen3 build/runtime issue affecting v45.2.x.
Changes:
- Adds a Spack
patch()entry pulling the upstream ACTS PR #5244 patch. - Restricts the patch application to ACTS 45.2-series versions.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Add patch for SurfaceArrayNavigationPolicy destructor fix
wdconinc
changed the title
Contributor
Author
|
Builds successfully in eic/containers#293. |
veprbl
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.
This PR backports a few small
actsPRs (acts-project/acts#5244, acts-project/acts#5192) to v45.2, needed to fix https://eicweb.phy.anl.gov/containers/eic_container/-/jobs/7853983#L287 and https://eicweb.phy.anl.gov/containers/eic_container/-/jobs/7855187#L430. They apply cleanly to 45.2.0. Passed over in local testing.What is the urgency of this PR?
What kind of change does this PR introduce?
Please check if any of the following apply