pyrobird: limit setuptools to :76 due to project.license#908
Open
wdconinc wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the Spack recipe for pyrobird to avoid newer setuptools behavior that breaks builds when a project uses the deprecated project.license field in pyproject.toml. The change aligns dependency resolution with the known-working setuptools range for [email protected]:.
Changes:
- Constrain the build dependency on
py-setuptoolsfor[email protected]:to@61:76to prevent selecting newersetuptoolsversions that reject deprecatedproject.license.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
7cc4825 to
23349e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.
Since
pyrobirduses the deprecated project.license in pyproject.toml, we should restrict setuptools to at most 76.What is the urgency of this PR?
What kind of change does this PR introduce?
Please check if any of the following apply