refactor: navigation and bottom sheet 2#685
Open
tvillega wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of #491.
What's new
com.cappielloantonio.tempo.navigationas its behavior depends on it.BaseFragmentfragment.getNavigationController()getBottomSheetController()getNavController()The goal is to mimic the behavior of
getActivity(), which is available globally in the fragment context.What's deprecated
The following global, public variables from MainActivity:
navControllerbottomSheetBheaviorAre no longer required to be global nor public and are candidate for removal. Fragments must now inherit from
BaseFragmentto interact with Navigation and BottomSheet to stop polluting MainActivity with functions.What's safe to remove
The following public functions:
setBottomSheetInPeek()setBottomSheetVisibility()collapseBottomSheetDelayed()expandBottomSheet()setBottomSheetDraggableState()animateBottomSheet()setBottomNavigationBarVisibility()setNavigationDrawerLock()isNavigationDrawerLocked()toggleNavigationDrawerLockOnOrientationChange()setSystemBarsVisibility()Are now only wrappers from the Navigation and BottomSheet controllers and can be removed from MainActivity. Unfortunately, this requires to modify all the fragments in
com.cappielloantonio.tempo.ui.fragmentfor them to inherit fromBaseFragmentand stop summoning the methods from MainActivity.By encapsulating the Navigation and BottomSheet the code will become more legible and, hence, maintainable.