Skip to content

Feature/update oras6 clipping#85

Closed
RachelFurner wants to merge 3 commits into
mainfrom
feature/UpdateOras6Clipping
Closed

Feature/update oras6 clipping#85
RachelFurner wants to merge 3 commits into
mainfrom
feature/UpdateOras6Clipping

Conversation

@RachelFurner
Copy link
Copy Markdown

@RachelFurner RachelFurner commented Apr 11, 2025

Description

Replicated lines relating to tos (surface temperatue) in src/anemoi/transform/filters/oras6_clipping.py to deal with all currently used temperature levels (thetao_?).

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Issue Number

This would close issue 84

Code Compatibility

  • [ x] I have performed a self-review of my code

Code Performance and Testing

  • I have added tests that prove my fix is effective or that my feature works
  • I ran the complete Pytest test suite locally, and they pass

Dependencies

  • [ x] I have ensured that the code is still pip-installable after the changes and runs
  • [x ] I have tested that new dependencies themselves are pip-installable.

Documentation

  • My code follows the style guidelines of this project
  • I have updated the documentation and docstrings to reflect the changes
  • I have added comments to my code, particularly in hard-to-understand areas

Additional Notes

This change is relatively small, effecting only one file, and expands on current work, so no new documentation seems necessary.

@FussyDuck
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@lzampier
Copy link
Copy Markdown
Member

Hi @RachelFurner. As it is, this version breaks my 2D ocean requests because the variables are not optional. An interim solution would be to implement the 3D clipping in a different filter. The best option would be to make variables optional. I can give option 2 a go. If you are in a rush I suggest you start with option 1.

@RachelFurner
Copy link
Copy Markdown
Author

Hi @RachelFurner. As it is, this version breaks my 2D ocean requests because the variables are not optional. An interim solution would be to implement the 3D clipping in a different filter. The best option would be to make variables optional. I can give option 2 a go. If you are in a rush I suggest you start with option 1.

Hi @lzampier, sorry about that! I don't think this is gonna get to a stage where we can build the dataset this week, so better to do it properly than quickly, and make the variables optional. It would be fab ff you can have a go at that, thanks! Please can you make it so tos is also optional -- just to allow full flexibility for any future plans.

@floriankrb
Copy link
Copy Markdown
Member

already implemented in #96

@floriankrb floriankrb closed this Jun 13, 2025
@github-project-automation github-project-automation Bot moved this from Now In Progress to Done in Anemoi-dev Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants