refactor: simplify MatchingFieldsFilter by removing matching decorator#289
Merged
Conversation
Contributor
anaprietonem
left a comment
anaprietonem
left a comment
There was a problem hiding this comment.
Nice work Aaron, I like this new implementation. Left some comments & questions. Guess we'd also need to update the docs with this PR?
github-actions
Bot
added
the
documentation
anaprietonem
approved these changes
Apr 29, 2026
Contributor
anaprietonem
left a comment
anaprietonem
left a comment
There was a problem hiding this comment.
Thanks Aaron for addressing my comments, LGTM!
github-project-automation
Bot
moved this from To be triaged
to For merging
in Anemoi-dev
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Simplifies the
MatchingFieldsFilterby removing thematchingdecorator and instead using a simple dataclass as a class variable. Should replicate existing behaviour, except errors/warnings are now issued at initialisation time rather than filter use time.As a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/
By opening this pull request, I affirm that all authors agree to the Contributor License Agreement.
📚 Documentation preview 📚: https://anemoi-transform--289.org.readthedocs.build/en/289/