feat: add support for units compatibility#258
Merged
Conversation
Contributor
aaron-hopkinson
left a comment
aaron-hopkinson
left a comment
There was a problem hiding this comment.
Code itself looks fine - but here are some (optional) suggestions.
It might also be worth having some tests for the new functionality.
floriankrb
approved these changes
Apr 22, 2026
aaron-hopkinson
pushed a commit
that referenced
this pull request
Apr 22, 2026
🤖 Automated Release PR This PR was created by `release-please` to prepare the next release. Once merged: 1. A new version tag will be created 2. A GitHub release will be published 3. The changelog will be updated Changes to be included in the next release: --- ## [0.3.0](0.2.0...0.3.0) (2026-04-22) ### ⚠ BREAKING CHANGES * remove use of eval in tabular filters ([#278](#278)) ### Features * `apply-mask` (field) filter allows using another field as the mask ([#277](#277)) ([76074d4](76074d4)) * Add support for units compatibility ([#258](#258)) ([709dc72](709dc72)) * Deduplicate and reuse code from anemoi utils ([#281](#281)) ([c97ac48](c97ac48)) * Remove use of eval in tabular filters ([#278](#278)) ([b330a6d](b330a6d)) --- > [!IMPORTANT] > Please do not change the PR title, manifest file, or any other automatically generated content in this PR unless you understand the implications. Changes here can break the release process. >⚠️ Merging this PR will: > - Create a new release > - Trigger deployment pipelines > - Update package versions **Before merging:** - Ensure all tests pass - Review the changelog carefully - Get required approvals [Release-please documentation](https://github.com/googleapis/release-please)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add 'units' to the Variable class and implement checking of variables compatibility.
What problem does this change solve?
What issue or task does this change relate to?
Additional notes
As a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/
By opening this pull request, I affirm that all authors agree to the Contributor License Agreement.