chore: change raise NotImplementedError to raise TypeError#605
Merged
floriankrb merged 3 commits intoecmwf:mainfrom Apr 14, 2026
Merged
Conversation
floriankrb
reviewed
Apr 14, 2026
jfdev001
force-pushed
the
jfrazier/602-change-raise-not-implemented-to-pass
branch
from
33e1f2a to
2ad54e3
Compare
jfdev001
changed the title
Contributor
Author
|
@floriankrb The CI failure due to https://github.com/ecmwf/anemoi-datasets/actions/runs/24395197665/job/71260494246?pr=605#step:6:5416 showed up also in another PR i made (see #597 (comment)). I provided what i believe is a fix in that other PR here: |
Member
|
The failure is not related, so I merged your PR. And yes, you fix is also relevant, I implemented it there: #609 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Per python docs: built-in execptions#TypeError,
TypeErrorshould be used to indicate an operation is not supported. This PR replaces theNotImplementedError, which would imply one should implement the method, toTypeErrorto more clearly indicate the method is not meant to be implemented at all for children of the read-only class.What issue or task does this change relate to?
#602
As a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/
By opening this pull request, I affirm that all authors agree to the Contributor License Agreement.